Ignore status fields during drift detection #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
force-pushed
the
ignore-status-diff
branch
3 times, most recently
from
03f433c to
2fbbac3
Compare
aruiz14
force-pushed
the
ignore-status-diff
branch
from
3fa491a to
e985455
Compare
aruiz14
force-pushed
the
ignore-status-diff
branch
from
e985455 to
79b73ec
Compare
aruiz14
commented
Jun 20, 2024
e2e/drift/drift_test.go
Outdated
Comment on lines
188
to
196
| Context("Resource manifests containing status fields", func() { | ||
| It("Is marked as not ready", func() { | ||
| bundleName := "drift-correction-test-drift-ignore-status" | ||
| Eventually(func() bool { | ||
| b := getBundle(bundleName, k) | ||
| return b.Status.Summary.Ready == 1 | ||
| }).Should(BeTrue()) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
I tested this with an older version, and checked that it fails. The bundle never reaches a ready status:
❯ kubectl get bundle -n fleet-local -w drift-correction-test-drift-ignore-status
NAME BUNDLEDEPLOYMENTS-READY STATUS
drift-correction-test-drift-ignore-status 0/1 Modified(1) [Cluster fleet-local/local]; deployment.apps drift-ignore-status/nginx-deployment modified {"status":{"collisionCount":0}}
bigkevmcd
reviewed
Jun 20, 2024
aruiz14
force-pushed
the
ignore-status-diff
branch
from
ace0807 to
0478e62
Compare
bigkevmcd
previously approved these changes
Jun 20, 2024
aruiz14
changed the title
weyfonk
approved these changes
Jun 20, 2024
Tommy12789
pushed a commit
to Tommy12789/fleet
that referenced
this pull request
Jun 26, 2024
Tommy12789
pushed a commit
to Tommy12789/fleet
that referenced
this pull request
Jun 26, 2024
Tommy12789
pushed a commit
to Tommy12789/fleet
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2521
Use a new
StatusNormalizerwhen comparing deployed resources against the desired spec, sincestatusis normally not part of it.